New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide samples for Iterators (KT-20357) #1386

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tommykw
Contributor

tommykw commented Nov 6, 2017

@ilya-g ilya-g self-assigned this Nov 7, 2017

@ilya-g

In general it's not always necessary to assert something in a sample. So if you're illustrating for or forEach, you can just have its body like println(it).
Its output can't be checked in the sample source code for now, but we'll come up with something to make this check possible.

@tommykw

This comment has been minimized.

Show comment
Hide comment
@tommykw

tommykw Nov 8, 2017

Contributor

Thank you for the review. I will try to fix samples.

Contributor

tommykw commented Nov 8, 2017

Thank you for the review. I will try to fix samples.

@tommykw

This comment has been minimized.

Show comment
Hide comment
@tommykw

tommykw Nov 12, 2017

Contributor

Please take another look.

Contributor

tommykw commented Nov 12, 2017

Please take another look.

@ilya-g

This comment has been minimized.

Show comment
Hide comment
@ilya-g

ilya-g Dec 28, 2017

Contributor

Thank you, I've merged it with some corrections (dca23e3)

Contributor

ilya-g commented Dec 28, 2017

Thank you, I've merged it with some corrections (dca23e3)

@ilya-g ilya-g closed this Dec 28, 2017

@tommykw tommykw deleted the tommykw:add_iterators_sample branch Jan 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment