New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KT-20357 Add sample code Strings.toUpperCase #1600

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@katsutomu

katsutomu commented Apr 5, 2018

@ilya-g ilya-g self-assigned this Apr 13, 2018

@Sample
fun stringToUpperCase() {
assertPrints("Hello".toUpperCase(), "HELLO")
assertPrints("Hello".toUpperCase(Locale.ENGLISH), "HELLO")

This comment has been minimized.

@ilya-g

ilya-g Apr 19, 2018

Contributor

I wonder, is there such an example that shows why locale could be used for toUpper/LowerCase? I mean so that it would result in a different result compared to no locale overload.

This comment has been minimized.

@katsutomu

katsutomu May 5, 2018

@ilya-g
Thank you for review.
I understood that the following is unnecessary.
After excluding the following points,I will request a review again.

assertPrints("Hello".toUpperCase(Locale.ENGLISH), "HELLO")

@katsutomu

This comment has been minimized.

katsutomu commented May 5, 2018

@ilya-g
Fixed review.
I would appreciate it if you could review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment