From d3885fa8cab201812e0d35d5d4e544989175b146 Mon Sep 17 00:00:00 2001 From: Rashid Yangazov <129742127+RYangazov@users.noreply.github.com> Date: Wed, 8 May 2024 19:48:02 +0200 Subject: [PATCH] Add RotateSpec for parameters count minimization --- .../letsPlot/datamodel/svg/dom/slim/SlimBase.kt | 1 - docs/dev/notebooks/rotate_points.ipynb | 16 ++++++++-------- .../core/plot/base/aes/AestheticsUtil.kt | 8 +++----- .../core/plot/base/render/point/PointShapeSvg.kt | 13 +++++++++---- .../plot/base/render/point/UpdatableShape.kt | 4 +--- .../plot/base/render/point/symbol/GlyphPair.kt | 9 ++++----- .../base/render/point/symbol/MultiShapeGlyph.kt | 9 +++++---- .../base/render/point/symbol/SingletonGlyph.kt | 9 +++++---- .../base/render/point/symbol/TwoShapeGlyph.kt | 9 ++++----- 9 files changed, 39 insertions(+), 39 deletions(-) diff --git a/datamodel/src/commonMain/kotlin/org/jetbrains/letsPlot/datamodel/svg/dom/slim/SlimBase.kt b/datamodel/src/commonMain/kotlin/org/jetbrains/letsPlot/datamodel/svg/dom/slim/SlimBase.kt index a1033116ba8..4ac47d3821a 100644 --- a/datamodel/src/commonMain/kotlin/org/jetbrains/letsPlot/datamodel/svg/dom/slim/SlimBase.kt +++ b/datamodel/src/commonMain/kotlin/org/jetbrains/letsPlot/datamodel/svg/dom/slim/SlimBase.kt @@ -64,7 +64,6 @@ internal abstract class SlimBase protected constructor(val elementName: String) override fun setRotation(angle: Double, centerX: Double, centerY: Double) { if (angle != 0.0) { - //setAttribute(transform, "rotate($angle, $centerX, $centerY)") SvgTransformBuilder().rotate(angle, centerX, centerY).build().let { setAttribute(transform, it.toString()) } diff --git a/docs/dev/notebooks/rotate_points.ipynb b/docs/dev/notebooks/rotate_points.ipynb index 225323b8345..899f9170373 100644 --- a/docs/dev/notebooks/rotate_points.ipynb +++ b/docs/dev/notebooks/rotate_points.ipynb @@ -31,7 +31,7 @@ " \n", " \n", @@ -69,7 +69,7 @@ { "data": { "text/html": [ - "
\n", + " \n", " " ], "text/plain": [ - "