New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TeamCity metadata to that of an Instance Template #29
Add TeamCity metadata to that of an Instance Template #29
Conversation
updated properties log to use the base class for using toString() removed metadata details from log in case of sensitive info
Here are some testing logs from the metadata capture:
|
@dimyriy @dmitry-treskunov have you had a chance to take a look at the changes? I've been running this live for a couple of weeks now with no issues, and I'd like to weigh the possibility of pulling this to the master. |
@mohsenrezaeithe, thank you for contributing! The pull request looks good to be merged into master overall except the comment about logging.
...rver/src/main/kotlin/jetbrains/buildServer/clouds/google/connector/GoogleApiConnectorImpl.kt
Outdated
Show resolved
Hide resolved
@dimyriy thanks for reviewing! Good feedback, log details are removed. |
Thank you for contributing! |
This fixes https://youtrack.jetbrains.com/issue/TW-61898
Prior to the change the
getInstanceBuilder
was overwriting the Instance Template'sCustom metadata
with thesetMetadata
action.This change pulls the configured Instance Template's information from GCP and adds the existing metadata to the custom TeamCity server ones before setting it for the new instance. In addition, a new method,
getInstanceBuilder
, also avoids overwriting theAvailability policies
in the newly created instance as well (values are inherited from the Instance Template).All changes are tested in a staging environment with simulated workload.