Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #767 from Morganamilo/merge-dep-pool-order" #866

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@Morganamilo
Copy link
Collaborator

Morganamilo commented Jan 15, 2019

This reverts commit c2aeb4b, reversing
changes made to 1f1cee7.

This should fix the ton of recent issues which I assume are because of the depsolver changes. This will bring back the inner conflicts issues that prevent some circular dependencies from resolving. But they are rare enough compared to the ton of open issues right now.

Due to lack of time I'm just reverting the code, if I have time in future (or some one else wants to take on the task) then the code can be fixed and merged back in.

Revert "Merge pull request #767 from Morganamilo/merge-dep-pool-order"
This reverts commit c2aeb4b, reversing
changes made to 1f1cee7.
@Jguer

This comment has been minimized.

Copy link
Owner

Jguer commented Jan 17, 2019

I'm also in the same situation but I'll take the revert until this is sorted. I'm merging this, counseling every open thread to retry using this version and then we'll go from there

@Jguer Jguer merged commit 6354a44 into Jguer:master Jan 17, 2019

@Morganamilo

This comment has been minimized.

Copy link
Collaborator Author

Morganamilo commented Jan 18, 2019

I'm all for a release now. There's not too much going on right now and this fix is pretty important.

@Jguer

This comment has been minimized.

Copy link
Owner

Jguer commented Jan 20, 2019

Let's go for it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.