Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'Newly Registered Workshops' to the homepage #66

Open
wants to merge 2 commits into
base: master
from

Conversation

@tbutterwith
Copy link
Contributor

commented Sep 6, 2019

Summary

Shows the 5 most recently registered workshops in a list on the homepage.

Notes

I'm not 100% sure about the positioning - the github issue didn't specify so I don't know if it should sit higher or lower than the "upcoming talks" section. Happy to move things around.

I've also haven't written Ruby until this morning so if this isn't the right approach do let me know 馃槃

Closes #52


image

@JiggyPete

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2019

Having written no ruby until this morning you are on 馃敟 @tbutterwith 馃殌

<div class="row">
<ul class="list">
<% new_workshops.each do |workshop| %>
<li>

This comment has been minimized.

Copy link
@JiggyPete

JiggyPete Sep 7, 2019

Owner

Change Request: Use the existing (currently hidden) means of displaying a workshop on the homepage.

https://github.com/JiggyPete/global-diversity-cfp-day-site/blob/master/app/views/homepage/_workshops.html.erb#L11

This partial 鈽濓笍 displays all the workshops by continent and country and the block highlighted displays an individual workshop.

If we can extract that block to a new partial template file in app/views/homepage/_workshop.html.erb you can use it in your commit. The only other thing to do is pass in the workshop: workshop parameter from _workshops.html.erb and from your commit, then it'll be consistent when we get to launch.

image

This comment has been minimized.

Copy link
@tbutterwith

tbutterwith Sep 19, 2019

Author Contributor

Hey @JiggyPete, I think I understand. I've updated the PR. Let me know if I'm way off your thoughts.

tbutterwith added 2 commits Sep 6, 2019
add 'Newly Registered Workshops' to the homepage
Shows the 5 most recently registered workshops in a list on the homepage

@tbutterwith tbutterwith force-pushed the tbutterwith:latest-workshops branch from 4545332 to 86ae09b Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.