New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "::1" when the IP is unknown #110

Open
bemasc opened this Issue Oct 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@bemasc
Contributor

bemasc commented Oct 9, 2018

Currently, in error cases where there is an unknown or not-applicable IP address, it is rendered in the detailed view as "::1", i.e. IPv6 localhost. This has created significant confusion. We should properly track unknown IP addresses and show an explicit error message (maybe "N/A") instead.

@Stafedor

This comment has been minimized.

Show comment
Hide comment
@Stafedor

Stafedor Oct 12, 2018

Hello @bemasc, can I work on this issue ?

Stafedor commented Oct 12, 2018

Hello @bemasc, can I work on this issue ?

@bemasc

This comment has been minimized.

Show comment
Hide comment
@bemasc

bemasc Oct 12, 2018

Contributor

Definitely! I think the problem is here:

serverAddress = InetAddress.getByName(transaction.serverIp);

If we couldn't connect to the server, then serverIp is null. I thought this would generate an UnknownHostException, but it looks like it returns localhost instead.

Contributor

bemasc commented Oct 12, 2018

Definitely! I think the problem is here:

serverAddress = InetAddress.getByName(transaction.serverIp);

If we couldn't connect to the server, then serverIp is null. I thought this would generate an UnknownHostException, but it looks like it returns localhost instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment