New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block the UI thread during bootstrap #111

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@bemasc
Contributor

bemasc commented Oct 9, 2018

Fixes #103

@bemasc bemasc requested a review from alalamav Oct 9, 2018

@@ -53,13 +53,35 @@
private static final String LOG_TAG = "DnsVpnService";
private static final int SERVICE_ID = 1; // Only has to be unique within this app.
private static final String CHANNEL_ID = "vpn";
private static final String NO_PENDING_CONNECTION = "This value is not a possible URL.";

This comment has been minimized.

@alalamav

alalamav Oct 9, 2018

nit: maybe use a more standard sentinel value like "" or null?

@alalamav

alalamav Oct 9, 2018

nit: maybe use a more standard sentinel value like "" or null?

This comment has been minimized.

@bemasc

bemasc Oct 9, 2018

Contributor

Unfortunately that doesn't work here because null and "" are both treated as meaning "default server".

@bemasc

bemasc Oct 9, 2018

Contributor

Unfortunately that doesn't work here because null and "" are both treated as meaning "default server".

// The network manager is populated in onStartCommand. Its main function is to enable delayed

This comment has been minimized.

@alalamav

alalamav Oct 9, 2018

nice commenting ;)

@alalamav

alalamav Oct 9, 2018

nice commenting ;)

@bemasc bemasc merged commit de8d360 into master Oct 9, 2018

1 check passed

cla/google All necessary CLAs are signed

@bemasc bemasc deleted the bemasc-anr branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment