New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce fully event-driven proxy logic #122

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@bemasc
Contributor

bemasc commented Oct 16, 2018

I previously removed this logic because I suspected that it was creating an infinite busy-loop. This PR reintroduces it (in the first commit), and includes an improvement to make it robust against infinite loops (in the second commit).

bemasc added some commits Oct 16, 2018

Make proxy more robust against infinite loops
I don't have strong evidence that an infinite loop on await()
actually occurred, but this construction is more resistant to
infinite loops and also arguably easier to understand.

@bemasc bemasc requested a review from alalamav Oct 16, 2018

@bemasc bemasc merged commit 5f3c6fe into master Oct 16, 2018

1 check passed

cla/google All necessary CLAs are signed

@bemasc bemasc deleted the bemasc-poll branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment