New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count download bytes and early reset events #123

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@bemasc
Contributor

bemasc commented Oct 16, 2018

This should make it easier to monitor and improve the reliability
of the network subsystem.

Count download bytes and early reset events
This should make it easier to monitor and improve the reliability
of the network subsystem.

@bemasc bemasc requested a review from alalamav Oct 16, 2018

} else if (SocketPipe.OUTPUT_PIPE_NAME.equals(pipe.getName())){
remoteSocket = (Socket) pipe.getAttribute(SocketPipe.ATTR_DESTINATION_SOCKET);
} else {
remoteSocket = null;

This comment has been minimized.

@alalamav

alalamav Oct 16, 2018

You could return here, though I see the reason too keep the explicit check.

This comment has been minimized.

@bemasc

bemasc Oct 16, 2018

Contributor

Yeah, my thinking was that it would better to avoid two instances of return -1, i.e. the magic constant should only appear once.

}
/**
* This class converts pipe lifecycle callbacks into network reliability monitoring events.

This comment has been minimized.

@alalamav

alalamav Oct 16, 2018

Could you add a comment about the event (data structure) being sent?

This comment has been minimized.

@bemasc

bemasc Oct 16, 2018

Contributor

Done

Add event description comment
This also includes a change to tighten the conditions
for reporting EARLY_RESET.

@bemasc bemasc merged commit 4af3e15 into master Oct 16, 2018

1 check passed

cla/google All necessary CLAs are signed

@bemasc bemasc deleted the bemasc-counters branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment