Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more server options #172

Merged
merged 5 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@bemasc
Copy link
Contributor

commented May 2, 2019

This extends the included list of known providers from
two providers to seven. This required some UI changes and small
networking tweaks.

Fixes #91

@bemasc bemasc requested review from alalamav and dalyk May 2, 2019

@alalamav
Copy link
Contributor

left a comment

LGTM 👍


<string name="url2" translatable="false">https://dns.quad9.net/dns-query</string>
<string name="name2" translatable="false">Quad9 Secure DNS</string>
<string name="ips2" translatable="false">9.9.9.9,149,112.112.112,2620:fe::fe,2620:fe::fe:9</string>

This comment has been minimized.

Copy link
@alalamav

alalamav May 2, 2019

Contributor

Typo? 149

This comment has been minimized.

Copy link
@bemasc

bemasc May 3, 2019

Author Contributor

Thanks! Fixed.

<string name="url3" translatable="false">https://doh.cleanbrowsing.org/doh/security-filter/</string>
<string name="name3" translatable="false">CleanBrowsing Security Filter</string>
<string name="ips3" translatable="false">185.228.168.9,185.228.169.9,2a0d:2a00:1::2,2a0d:2a00:2::2</string>
<string name="description3">Global DNS filtering provider. Blocks malicious domains.</string>

This comment has been minimized.

Copy link
@alalamav

alalamav May 2, 2019

Contributor

nit: extra space after the period.

This comment has been minimized.

Copy link
@bemasc

bemasc May 3, 2019

Author Contributor

That's just, like, your opinion, man.

bemasc added some commits Apr 29, 2019

Add more server options
This extends the included list of known providers from
two providers to seven.  This required some UI changes and small
networking tweaks.

Fixes #91
Split table of servers into a separate file
This way, we should be able to remove entries from the
string-arrays (if necessary) by editing a single file,
instead of having to edit every locale's copy of servers.xml.
Temporarily remove PowerDNS from the list
We can add them back to the list once they post a privacy policy.

@bemasc bemasc force-pushed the bemasc-newservers branch from 8ab72ca to 1a5bc7b May 13, 2019

@bemasc bemasc merged commit 6df0e4f into master May 13, 2019

1 check passed

cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.