Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to change servers when one breaks #173

Merged
merged 4 commits into from May 15, 2019

Conversation

Projects
None yet
2 participants
@bemasc
Copy link
Contributor

commented May 6, 2019

Currently, it's not very clear what to do when queries
are failing. This change makes it clearer that users
have the option to switch servers, which might help.
When queries are failing, a button appears that gives
users a shortcut to the server settings dialog.

@bemasc bemasc requested a review from alalamav May 6, 2019

@alalamav
Copy link
Contributor

left a comment

👍

@@ -572,6 +576,10 @@ private void syncDnsStatus() {
final TextView indicatorText = controlView.findViewById(R.id.indicator);
indicatorText.setText(status.activationRequested ? R.string.indicator_on : R.string.indicator_off);

// Hide server change button by default
final Button changeServerButton = controlView.findViewById(R.id.change_server_button);
changeServerButton.setVisibility(View.INVISIBLE);

This comment has been minimized.

Copy link
@alalamav

alalamav May 7, 2019

Contributor

syncDnsStatus will get called when the new connection is set up, right? I was wondering if we needed to explicitly hide it.

This comment has been minimized.

Copy link
@bemasc

bemasc May 7, 2019

Author Contributor

Yes. If the VpnState changes, syncDnsStatus will get called again with the new state.

@bemasc bemasc force-pushed the bemasc-newservers branch from 8ab72ca to 1a5bc7b May 13, 2019

bemasc added some commits May 13, 2019

Add more server options
This extends the included list of known providers from
two providers to seven.  This required some UI changes and small
networking tweaks.

Fixes #91
Make it easier to change servers when one breaks
Currently, it's not very clear what to do when queries
are failing.  This change makes it clearer that users
have the option to switch servers, which might help.
When queries are failing, a button appears that gives
users a shortcut to the server settings dialog.

@bemasc bemasc force-pushed the bemasc-settings-link branch from c059af1 to 3b34b6f May 13, 2019

@bemasc bemasc merged commit d92384e into bemasc-newservers May 15, 2019

1 check passed

cla/google All necessary CLAs are signed

@bemasc bemasc deleted the bemasc-settings-link branch May 15, 2019

@bemasc bemasc restored the bemasc-settings-link branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.