Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in debug builds #177

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
None yet
2 participants
@bemasc
Copy link
Contributor

commented May 15, 2019

Unlike Firebase Crash Reporting, Crashlytics does not permit
the use of its logging functions when disabled in debug mode.
The easiest solution seems to be to avoid performing these
calls in debug builds.

@bemasc bemasc requested a review from alalamav May 15, 2019

@bemasc bemasc force-pushed the bemasc-crashlytics branch 2 times, most recently from 91a293f to f9daf08 May 15, 2019

Fix crash in debug builds
Unlike Firebase Crash Reporting, Crashlytics does not permit
the use of its logging functions when disabled in debug mode.
The easiest solution seems to be to avoid performing these
calls in debug builds.

@bemasc bemasc force-pushed the bemasc-crashlytics branch from f9daf08 to 9f6291c May 20, 2019

@alalamav
Copy link
Contributor

left a comment

Sorry for the delay!

@bemasc bemasc merged commit 3bb1bcf into master May 20, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bemasc bemasc deleted the bemasc-crashlytics branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.