Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Firebase Crashlytics #277

Merged
merged 1 commit into from Aug 18, 2020
Merged

Upgrade to Firebase Crashlytics #277

merged 1 commit into from Aug 18, 2020

Conversation

bemasc
Copy link
Contributor

@bemasc bemasc commented Aug 5, 2020

This requires increasing the minSdkVersion to 16, which unblocks a
number of other dependency upgrades and allows us to remove some version
checks.

@bemasc bemasc marked this pull request as draft August 5, 2020 21:15
This requires increasing the minSdkVersion to 16, which unblocks a
number of other dependency upgrades and allows us to remove some version
checks.
@bemasc
Copy link
Contributor Author

bemasc commented Aug 6, 2020

There's a lot of noise in this due to dependency tree upgrades, but you can hide them from the review with a file-type filter: https://github.com/Jigsaw-Code/Intra/pull/277/files?file-filters%5B%5D=.gradle&file-filters%5B%5D=.java&file-filters%5B%5D=.xml

@bemasc bemasc requested a review from alalamav August 6, 2020 16:39
@bemasc bemasc marked this pull request as ready for review August 6, 2020 16:39
@bemasc bemasc merged commit ee9e025 into master Aug 18, 2020
@bemasc bemasc deleted the bemasc-firebase branch August 18, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants