Release channels and staged releases for the manager #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalamav
reviewed
Sep 24, 2020
| @@ -21,16 +21,48 @@ if [ "$CSC_LINK" == "unset" ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| function usage () { | |||
There was a problem hiding this comment.
nit: can we can we move this code to a separate script (i.e. get_packaging_opts.sh) and call it from all the scripts?
added 5 commits
September 25, 2020 14:34
Also remove the alpha info chanel files since we aren't using them.
JonathanDCohen
commented
Sep 25, 2020
alalamav
approved these changes
Sep 28, 2020
JonathanDCohen
commented
Sep 30, 2020
|
|
||
| # This breaks if we have more than one option. We could, for example, use jq here to return JSON | ||
| # and jq from the calling script to parse it to variables. | ||
| echo "${STAGING_PERCENTAGE}" |
There was a problem hiding this comment.
This doesn't quite work as you propose, since subprocesses get a copy of the parent process' environment. I did some research, however, and found that scripts called with source run in the same process as the caller, and so can populate variables without them even needing to be exported to the environment at all! Thanks for the motivation to find a better solution ^_^
Done in 3ba6a3c
There was a problem hiding this comment.
Glad my suggestion helped 😅
alalamav
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to release a beta or alpha build of the manager by appending "-beta" or "-alpha" to the version field in the manager's
package.json. It also allows us to perform a staged rollout by appending-s $rollout_percentageto the build command. This is similar to Jigsaw-Code/outline-apps#841 for the client.This PR adds jq to parse
package.jsonas a system dependency requirement for packaging or releasing the manager in order to parsepackage.json