Skip to content

Conversation

@Khurdhula-Harshavardhan
Copy link
Collaborator

Updated the request handling logic in both the asynchronous (jigsawstack/async_request.py) and synchronous (jigsawstack/request.py) request modules to better support raw data payloads. The main improvement is the addition of logic to correctly pass raw data when present, enhancing flexibility for different types of HTTP requests.

Request payload handling improvements:

  • Both make_request methods now assign self.data to a local variable for easier access and processing. [1] [2]
  • Added a conditional branch to check for raw data (data) and set the request payload accordingly, ensuring that raw data requests are handled properly in both async and sync flows. [1] [2]

Copy link
Collaborator

@winzamark123 winzamark123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winzamark123 winzamark123 merged commit c70c061 into main Sep 17, 2025
18 checks passed
@winzamark123 winzamark123 deleted the fix/binary-upload branch September 17, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants