Skip to content

Please make org.joda.money.CurrencyUnit.registerCurrency public #17

Closed
michaelklishin opened this Issue Apr 11, 2013 · 0 comments

1 participant

@michaelklishin

org.joda.money.CurrencyUnit.registerCurrency is currently package-visible, which means the only ways to register a currency is by either placing org/joda/money/MoneyDataExtension.csv on classpath or using a completely new currency provider.

The latter is no possible for a library. The former is not a very good idea because it potentially prevents apps from using this extension mechanism (two resources with the same name of classpath is a famous source of head scratching and heisenbugs).

I can't think of a downside to making registerCurrency public, please consider making it so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.