From 66c4a1c10d33243fb0a6f850d350226ab4d55a6c Mon Sep 17 00:00:00 2001 From: Stephen Colebourne Date: Wed, 6 Jun 2012 11:35:56 +0100 Subject: [PATCH] Change some StringBuffer uses to StringBuilder [3532330] --- RELEASE-NOTES.txt | 1 + src/main/java/org/joda/time/IllegalFieldValueException.java | 2 +- src/main/java/org/joda/time/Partial.java | 2 +- src/main/java/org/joda/time/chrono/BasicChronology.java | 2 +- src/main/java/org/joda/time/convert/ConverterSet.java | 2 +- src/main/java/org/joda/time/format/DateTimeFormat.java | 2 +- src/main/java/org/joda/time/tz/ZoneInfoProvider.java | 2 +- 7 files changed, 7 insertions(+), 6 deletions(-) diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index 326536911..c1feff5c1 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -21,6 +21,7 @@ of restrictions. If the license causes you problems please contact the mailing l Enhancements since 2.1 ---------------------- +- Change some StringBuffer uses to StringBuilder [3532330] Compatibility with 2.1 diff --git a/src/main/java/org/joda/time/IllegalFieldValueException.java b/src/main/java/org/joda/time/IllegalFieldValueException.java index f3184f2cb..f588a853a 100644 --- a/src/main/java/org/joda/time/IllegalFieldValueException.java +++ b/src/main/java/org/joda/time/IllegalFieldValueException.java @@ -38,7 +38,7 @@ public class IllegalFieldValueException extends IllegalArgumentException { */ private static String createMessage(String fieldName, Number value, Number lowerBound, Number upperBound, String explain) { - StringBuffer buf = new StringBuffer() + StringBuilder buf = new StringBuilder() .append("Value ").append(value).append(" for ").append(fieldName).append(' '); if (lowerBound == null) { diff --git a/src/main/java/org/joda/time/Partial.java b/src/main/java/org/joda/time/Partial.java index 967308905..aaf0a0fd5 100644 --- a/src/main/java/org/joda/time/Partial.java +++ b/src/main/java/org/joda/time/Partial.java @@ -760,7 +760,7 @@ public String toString() { */ public String toStringList() { int size = size(); - StringBuffer buf = new StringBuffer(20 * size); + StringBuilder buf = new StringBuilder(20 * size); buf.append('['); for (int i = 0; i < size; i++) { if (i > 0) { diff --git a/src/main/java/org/joda/time/chrono/BasicChronology.java b/src/main/java/org/joda/time/chrono/BasicChronology.java index b0bd3d344..e0831f70b 100644 --- a/src/main/java/org/joda/time/chrono/BasicChronology.java +++ b/src/main/java/org/joda/time/chrono/BasicChronology.java @@ -214,7 +214,7 @@ public int hashCode() { * @return a debugging string */ public String toString() { - StringBuffer sb = new StringBuffer(60); + StringBuilder sb = new StringBuilder(60); String name = getClass().getName(); int index = name.lastIndexOf('.'); if (index >= 0) { diff --git a/src/main/java/org/joda/time/convert/ConverterSet.java b/src/main/java/org/joda/time/convert/ConverterSet.java index a238117b7..d571c64e0 100644 --- a/src/main/java/org/joda/time/convert/ConverterSet.java +++ b/src/main/java/org/joda/time/convert/ConverterSet.java @@ -298,7 +298,7 @@ private static Converter selectSlow(ConverterSet set, Class type) { // Class c implements a, b {} // Converters exist only for a and b. Which is better? Neither. - StringBuffer msg = new StringBuffer(); + StringBuilder msg = new StringBuilder(); msg.append("Unable to find best converter for type \""); msg.append(type.getName()); msg.append("\" from remaining set: "); diff --git a/src/main/java/org/joda/time/format/DateTimeFormat.java b/src/main/java/org/joda/time/format/DateTimeFormat.java index 9afaf93c1..2639f9add 100644 --- a/src/main/java/org/joda/time/format/DateTimeFormat.java +++ b/src/main/java/org/joda/time/format/DateTimeFormat.java @@ -571,7 +571,7 @@ private static void parsePatternTo(DateTimeFormatterBuilder builder, String patt * @return the parsed token */ private static String parseToken(String pattern, int[] indexRef) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); int i = indexRef[0]; int length = pattern.length(); diff --git a/src/main/java/org/joda/time/tz/ZoneInfoProvider.java b/src/main/java/org/joda/time/tz/ZoneInfoProvider.java index a1eff91ab..ff36abbee 100644 --- a/src/main/java/org/joda/time/tz/ZoneInfoProvider.java +++ b/src/main/java/org/joda/time/tz/ZoneInfoProvider.java @@ -203,7 +203,7 @@ private InputStream openResource(String name) throws IOException { in = ClassLoader.getSystemResourceAsStream(path); } if (in == null) { - StringBuffer buf = new StringBuffer(40) + StringBuilder buf = new StringBuilder(40) .append("Resource not found: \"") .append(path) .append("\" ClassLoader: ")