Enable SNI Support

[apeschel]

This commit enables SNI support, as per

https://blogs.oracle.com/meena/entry/apachebench_ab_and_sni

[JoeDog]

Aaron,

This looks good but what about support for older versions of openssl? Can I
safely address that like this:

#if defined(SSL_CTRL_SET_TLSEXT_HOSTNAME)
SSL_ctrl(C->ssl, SSL_CTRL_SET_TLSEXT_HOSTNAME, TLSEXT_NAMETYPE_host_name,
(char _)servername);
#endif/_SSL_CTRL_SET_TLSEXT_HOSTNAME*/

Jeff

On Tue, Aug 25, 2015 at 7:36 PM, Aaron Peschel notifications@github.com
wrote:

This commit enables SNI support, as per

https://blogs.oracle.com/meena/entry/apachebench_ab_and_sni

You can view, comment on, or merge this pull request online at:

#25
Commit Summary

• Enable SNI Support

File Changes

• M src/client.c
  https://github.com/JoeDog/siege/pull/25/files#diff-0 (2)
• M src/ssl.c https://github.com/JoeDog/siege/pull/25/files#diff-1
  (5)
• M src/ssl.h https://github.com/JoeDog/siege/pull/25/files#diff-2
  (2)
• M src/url.c https://github.com/JoeDog/siege/pull/25/files#diff-3
  (28)
• M src/url.h https://github.com/JoeDog/siege/pull/25/files#diff-4
  (29)

Patch Links:

• https://github.com/JoeDog/siege/pull/25.patch
• https://github.com/JoeDog/siege/pull/25.diff

—
Reply to this email directly or view it on GitHub
#25.

[JoeDog]

Aaron,

I'm not going to implement the url.* changes. The whole idea behind
encapsulation is to disallow direct access to those variables. In client.c
we get the hostname with the getter:

if (SSL_initialize(C, url_get_hostname(U))==FALSE) {
  return FALSE;
}

Regards,
J.

On Wed, Aug 26, 2015 at 9:25 AM, Jeff Fulmer jeff@joedog.org wrote:

Aaron,

This looks good but what about support for older versions of openssl? Can
I safely address that like this:

#if defined(SSL_CTRL_SET_TLSEXT_HOSTNAME)
SSL_ctrl(C->ssl, SSL_CTRL_SET_TLSEXT_HOSTNAME,
TLSEXT_NAMETYPE_host_name, (char _)servername);
#endif/_SSL_CTRL_SET_TLSEXT_HOSTNAME*/

Jeff

On Tue, Aug 25, 2015 at 7:36 PM, Aaron Peschel notifications@github.com
wrote:

This commit enables SNI support, as per

https://blogs.oracle.com/meena/entry/apachebench_ab_and_sni

You can view, comment on, or merge this pull request online at:

#25
Commit Summary

• Enable SNI Support

File Changes

• M src/client.c
  https://github.com/JoeDog/siege/pull/25/files#diff-0 (2)
• M src/ssl.c https://github.com/JoeDog/siege/pull/25/files#diff-1
  (5)
• M src/ssl.h https://github.com/JoeDog/siege/pull/25/files#diff-2
  (2)
• M src/url.c https://github.com/JoeDog/siege/pull/25/files#diff-3
  (28)
• M src/url.h https://github.com/JoeDog/siege/pull/25/files#diff-4
  (29)

Patch Links:

• https://github.com/JoeDog/siege/pull/25.patch
• https://github.com/JoeDog/siege/pull/25.diff

—
Reply to this email directly or view it on GitHub
#25.

[apeschel]

@JoeDog Your define guard seems like a good solution for backwards compatibility. I'll spend a bit of time to see if there is any other option, but your suggestion is probably the best.

The url.* objection is reasonable - I just didn't notice the getter while trying to get the code to compile.

[apeschel]

PR has been merged in by hand.