Navigation Menu

Skip to content

Commit

Permalink
Merge pull request wireservice#358 from mikemee/patch-1
Browse files Browse the repository at this point in the history
Grammar nazi
  • Loading branch information
onyxfish committed Nov 16, 2014
2 parents 30db4b4 + 183ce1b commit 9d7edd9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/contributing.rst
Expand Up @@ -33,7 +33,7 @@ Contributors should use the following roadmap to guide them through the process
#. Comment on the ticket letting everyone know you're going to be hacking on it so that nobody duplicates your effort. It's also good practice to provide some general idea of how you plan on resolving the issue so that other developers can make suggestions.
#. Write tests for the feature you're building. Follow the format of the existing tests in the test directory to see how this works. You can run all the tests with the command ``nosetests``. The one exception to testing is command-line scripts. These don't need unit test, though all reusable components should be factored into library modules.
#. Write the code. Try to stay consistent with the style and organization of the existing codebase. A good patch won't be refused for stylistic reasons, but large parts of it may be rewritten and nobody wants that.
#. As your coding, periodically merge in work from the master branch and verify you haven't broken anything by running the test suite.
#. As you're coding, periodically merge in work from the master branch and verify you haven't broken anything by running the test suite.
#. Write documentation for user-facing features (and library features once the API has stabilized).
#. Once it works, is tested, and has documentation, submit a pull request on Github.
#. Wait for it to either be merged or to recieve a comment about what needs to be fixed.
Expand Down

0 comments on commit 9d7edd9

Please sign in to comment.