Permalink
Browse files

fixed the logic so it goes to better defaults and doesn't show duplic…

…ates for new rows.
  • Loading branch information...
1 parent c05a3a7 commit ac3500b40139778aa59c220305b962899b657d15 @JoelJ committed Jun 9, 2012
Showing with 3 additions and 3 deletions.
  1. +3 −3 src/main/resources/com/attask/jenkins/dashboard/JobColumn/config.jelly
@@ -8,11 +8,11 @@
<f:entry title="Hidden" field="hidden">
<!--use the select fields rather than checkbox so the value is always posted to the server-->
<select name="hidden">
- <j:if test="${instance == null || instance.hidden}">
+ <j:if test="${instance != null and instance.hidden}">
<option value="false">Show by default</option>
<option selected="true" value="true">Hide by default</option>
</j:if>
- <j:if test="${!instance.hidden}">
+ <j:if test="${instance == null || !instance.hidden}">
<option selected="true" value="false">Show by default</option>
<option value="true">Hide by default</option>
</j:if>
@@ -25,7 +25,7 @@
<option selected="true" value="true">Require this job to pass to consider the row passed</option>
<option value="false">Do not require this job to pass to consider the row passed</option>
</j:if>
- <j:if test="${!instance.required}">
+ <j:if test="${instance != null and !instance.required}">
<option value="true">Require this job to pass to consider the row passed</option>
<option selected="true" value="false">Do not require this job to pass to consider the row passed</option>
</j:if>

0 comments on commit ac3500b

Please sign in to comment.