Skip to content

react & react-dom should be declared in peerDependencies section #10

@chenxinyanc

Description

@chenxinyanc

We are currently using this package on react 18 / react-dom 18, but our package manager decides to install a duplicate react 17 / react-dom 17 because the version spec in the package.json has restricted the react major version to be 17

https://github.com/Joeyonng/react-jupyter-notebook/blob/deddebcce78180818ba0d8479edf09f86f42f9ed/package.json#L34-35

Could you please

  1. Loosen the react version spec from ^17.0.1 to >=17.0.1
  2. Declare dependency to react / react-dom in peerDependencies section?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions