From c8187e004a718979ddbfa76ff5808452e3ac17d3 Mon Sep 17 00:00:00 2001 From: Guillaume Louel Date: Fri, 2 Nov 2018 13:10:10 +0100 Subject: [PATCH 1/2] Move b4-3 apple descriptions to b10-3 --- Aerial/Source/Models/ManifestLoader.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Aerial/Source/Models/ManifestLoader.swift b/Aerial/Source/Models/ManifestLoader.swift index 5f439532..cac1c957 100644 --- a/Aerial/Source/Models/ManifestLoader.swift +++ b/Aerial/Source/Models/ManifestLoader.swift @@ -72,12 +72,12 @@ class ManifestLoader { "b4-2": "N008_C003_", // New York night 2 "b8-2": "A008_C007_", // San Francisco day 1 - "b10-3": "A013_C005_", // San Francisco day 2 + // "b10-3": , // San Francisco day 2 "b9-3": "A006_C003_", // San Francisco day 3 //"b8-3":"", San Francisco day 4 (no extra poi ?) "b3-3": "A012_C014_", // San Francisco day 5 // maybe A013_C004 ? - "b4-3": "A013_C012_", // San Francisco day 6 + "b4-3": "A013_C005_", // San Francisco day 6 "b6-4": "A004_C012_", // San Francisco night 1 "b7-3": "A007_C017_", // San Francisco night 2 "b5-3": "A015_C014_", // San Francisco night 3 From 174b8df73828aa6ef1464e0ca49cba07646965e8 Mon Sep 17 00:00:00 2001 From: Guillaume Louel Date: Sat, 3 Nov 2018 13:18:06 +0100 Subject: [PATCH 2/2] Last fixes for 1.4.5 --- .../PreferencesWindowController.swift | 20 +++++++++++++++++++ Resources/PreferencesWindow.xib | 11 ++++++---- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/Aerial/Source/Controllers/PreferencesWindowController.swift b/Aerial/Source/Controllers/PreferencesWindowController.swift index 953ce773..649167b1 100644 --- a/Aerial/Source/Controllers/PreferencesWindowController.swift +++ b/Aerial/Source/Controllers/PreferencesWindowController.swift @@ -418,6 +418,10 @@ class PreferencesWindowController: NSWindowController, NSOutlineViewDataSource, if preferences.darkModeNightOverride { overrideNightOnDarkMode.state = .on } + // We disable the checkbox if we are on nightShift mode + if preferences.timeMode == Preferences.TimeMode.lightDarkMode.rawValue { + overrideNightOnDarkMode.isEnabled = false + } } else { overrideNightOnDarkMode.isEnabled = false } @@ -1039,6 +1043,12 @@ class PreferencesWindowController: NSWindowController, NSOutlineViewDataSource, // MARK: - Time panel + @IBAction func overrideNightOnDarkModeClick(_ button: NSButton) { + let onState = (button.state == NSControl.StateValue.on) + preferences.darkModeNightOverride = onState + debugLog("UI overrideNightDarkMode: \(onState)") + } + @IBAction func enterCoordinatesButtonClick(_ sender: Any) { if enterCoordinatesPanel.isVisible { enterCoordinatesPanel.close() @@ -1052,6 +1062,16 @@ class PreferencesWindowController: NSWindowController, NSOutlineViewDataSource, } @IBAction func timeModeChange(_ sender: NSButton?) { + debugLog("UI timeModeChange") + if sender == timeLightDarkModeRadio { + print("dis") + overrideNightOnDarkMode.isEnabled = false + } else { + if #available(OSX 10.14, *) { + overrideNightOnDarkMode.isEnabled = true + } + } + if sender == timeDisabledRadio { preferences.timeMode = Preferences.TimeMode.disabled.rawValue } else if sender == timeNightShiftRadio { diff --git a/Resources/PreferencesWindow.xib b/Resources/PreferencesWindow.xib index a54a0684..15ad328c 100644 --- a/Resources/PreferencesWindow.xib +++ b/Resources/PreferencesWindow.xib @@ -904,7 +904,7 @@ should appear - + @@ -1149,12 +1149,15 @@ Shift, but macOS 10.12.4 or above and a compatible Mac are required)