Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support class selectors #7

Closed
lz100 opened this issue Jul 27, 2020 · 1 comment
Closed

Support class selectors #7

lz100 opened this issue Jul 27, 2020 · 1 comment

Comments

@lz100
Copy link
Contributor

@lz100 lz100 commented Jul 27, 2020

I think the driver js support selecting by class,

driver.highlight('.class')

Your selector is forced to paste the "#" id selector, is it possible to open for other selectors or an additional argument to optionally add add the "#" and set it to TRUE by default? Old users will not notice the difference

highlight = function(el, session = NULL, by_id = TRUE){
    if(by_id) el <- paste0("#", el)
    ...
}
@JohnCoene JohnCoene closed this in 4300444 Jul 27, 2020
@JohnCoene
Copy link
Owner

@JohnCoene JohnCoene commented Jul 27, 2020

Indeed, I had thought most would be just happy with id but it's limiting the use of the underlying library.

I have added a is_id argument to the step and highlight methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.