Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@media print css behavior #159

Closed
sdmcallister opened this issue Jun 2, 2020 · 2 comments
Closed

@media print css behavior #159

sdmcallister opened this issue Jun 2, 2020 · 2 comments

Comments

@sdmcallister
Copy link

@sdmcallister sdmcallister commented Jun 2, 2020

Not sure if this is the right place to file this issue. The default image behaviour when printing to PDF from a browser can result in images to be split across pages which looks bad. To fix this I've added a snippet to my custom CSS file:

@media print {
  div.echarts4r.html-widget.html-widget-static-bound { 
    page-break-inside: avoid;
  }
}

Can/should this be added as default behaviour?

@JohnCoene
Copy link
Owner

@JohnCoene JohnCoene commented Jun 2, 2020

Hi Steve, that sounds like a good idea to me! Feel free to create a pull request, otherwise I can add it myself. Thanks you!

@JohnCoene JohnCoene closed this in a82ae68 Jun 16, 2020
@JohnCoene
Copy link
Owner

@JohnCoene JohnCoene commented Jun 16, 2020

Added that to the package, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.