`name` argument of `e_boxplot_` is unused

[ttzhou]

In e_boxplot_, name is one of the accepted arguments, but it is not actually used anywhere in the function body. Would it make sense to add in the code for e_boxplot_, where it says

function (e, serie, name = NULL, outliers = TRUE, ...) 
{
    if (missing(serie)) 
        stop("must pass serie", call. = FALSE)
    for (i in 1:length(e$x$data)) {
        vector <- .build_boxplot(e, serie, i)
        if (!e$x$tl) {
            ## no if statement here (original)
            nm <- .name_it(e, serie, NULL, i)
            if (length(e$x$opts$series) >= 1) {
                e$x$opts$series[[1]]$data <- append(e$x$opts$series[[1]]$data, 
                  list(vector))
            }
            else {
                box <- list(name = nm, type = "boxplot", data = list(vector), 
                  ...)
                e$x$opts$series <- append(e$x$opts$series, list(box))
            }
            if (isTRUE(outliers)) {
                e <- .add_outliers(e, serie, i)
            }
            e$x$opts$xAxis[[1]]$data <- append(e$x$opts$xAxis[[1]]$data, 
                list(nm))
            e$x$opts$xAxis[[1]]$type <- "category"
        }
        else {
            e$x$opts$options[[i]]$series <- append(e$x$opts$options[[i]]$series, 
                list(list(data = vector)))
        }
    }
    if (isTRUE(e$x$tl)) {
        serie_opts <- list(type = "boxplot", ...)
        e$x$opts$baseOption$series <- append(e$x$opts$baseOption$series, 
            list(serie_opts))
    }
    e
}

to

function (e, serie, name = NULL, outliers = TRUE, ...) 
{
    if (missing(serie)) 
        stop("must pass serie", call. = FALSE)
    for (i in 1:length(e$x$data)) {
        vector <- .build_boxplot(e, serie, i)
        if (!e$x$tl) {
            ## add check
            if (!name) {
             nm <- .name_it(e, serie, NULL, i)
           } else {
             nm <- name
           }
            if (length(e$x$opts$series) >= 1) {
                e$x$opts$series[[1]]$data <- append(e$x$opts$series[[1]]$data, 
                  list(vector))
            }
            else {
                box <- list(name = nm, type = "boxplot", data = list(vector), 
                  ...)
                e$x$opts$series <- append(e$x$opts$series, list(box))
            }
            if (isTRUE(outliers)) {
                e <- .add_outliers(e, serie, i)
            }
            e$x$opts$xAxis[[1]]$data <- unique(append(e$x$opts$xAxis[[1]]$data, 
                list(nm)))
            e$x$opts$xAxis[[1]]$type <- "category"
        }
        else {
            e$x$opts$options[[i]]$series <- append(e$x$opts$options[[i]]$series, 
                list(list(data = vector)))
        }
    }
    if (isTRUE(e$x$tl)) {
        serie_opts <- list(type = "boxplot", ...)
        e$x$opts$baseOption$series <- append(e$x$opts$baseOption$series, 
            list(serie_opts))
    }
    e
}

[JohnCoene]

I've done differently but the name argument is now taken into account. Thanks for flagging.

[ttzhou]

Thanks! Totally didn't consider that there was already a name argument to .name_it. 🤦