-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using 'hide_on_render=TRUE' on a plot, does not work #94
Comments
Thanks, well spotted. I just changed it to use |
Thanks for the quick response. On the same topic, items are added to these three arrays but they are never removed. Shouldn't they? Should I call |
One more thing: how do we specify from server side the Perhaps there is no need for three separate arrays. Is there a scenario where a user would want the spinner (in this auto-hide case) to continue in case of an error? |
And another thing (sorry, I just write what I notice, when I use the waiter_show on a plot render): |
Thanks for this! I'll be honest I have not taken care of the You can specify the arguments you ask about here: Line 373 in 8cdb0e2
|
Hi,
using
hide_on_render=TRUE
on a ggplot fails to hide the waiter after the value(or error) Shiny events.I noticed some errors in the javascript code (waiter.js):
Javascript arrays are 0 based. So the comparison above will naturally become false, even if the correct element is in the array with index 0.
This is the correct way:
This should be changed for operations in all three arrays:
waiter_to_hide
,waiter_to_hide_on_error
,waiter_to_hide_on_silent_error
. And perhaps on other javascript files too?The text was updated successfully, but these errors were encountered: