Skip to content

Fix #26 by setting dialogue option's texts as wrap#27

Merged
JohnCorby merged 1 commit into
JohnCorby:masterfrom
TRSasasusu:fix-overflow-dialogue-option-cjk
Jan 19, 2025
Merged

Fix #26 by setting dialogue option's texts as wrap#27
JohnCorby merged 1 commit into
JohnCorby:masterfrom
TRSasasusu:fix-overflow-dialogue-option-cjk

Conversation

@TRSasasusu
Copy link
Copy Markdown
Contributor

This pull request resolves #26.
スクリーンショット (6754)
スクリーンショット (6755)
スクリーンショット (6757)

@TRSasasusu TRSasasusu changed the title Fix #26 by setting dialogue option's texts as unwrap Fix #26 by setting dialogue option's texts as wrap Nov 20, 2024
@TRSasasusu TRSasasusu force-pushed the fix-overflow-dialogue-option-cjk branch from 7828cfc to 1e7701f Compare November 20, 2024 13:45
@TRSasasusu
Copy link
Copy Markdown
Contributor Author

As did in the base game, I should manually put line breaks on each dialogue option, maybe.
So, I temporarily close this pull request.

@TRSasasusu
Copy link
Copy Markdown
Contributor Author

I made a specific pull request for Christmas Story in only Japanese: hearth1an/hearth1an.ChristmasStory#54
However, this vanilla fix's pull request resolves the issue in all CJK languages, and it is NOT conflicting with the Christmas Story's pull request.
Therefore, I revive it now. Thanks.

@TRSasasusu TRSasasusu reopened this Nov 23, 2024
@JohnCorby JohnCorby merged commit 01e8109 into JohnCorby:master Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In CJK languages, the text field of dialogue options can be overflow when the UI size is standard

2 participants