Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added some files that are generated by unit tests to the git ignore, … #588

Merged
merged 1 commit into from Aug 15, 2019
Merged

added some files that are generated by unit tests to the git ignore, … #588

merged 1 commit into from Aug 15, 2019

Conversation

alexander-n-thomas
Copy link
Contributor

@alexander-n-thomas alexander-n-thomas commented Aug 12, 2019 •
edited

…and added scoverage for unit test coverage

just added scoverage to build

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@saif-ellafi saif-ellafi merged commit 2f29cfb into master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexander-n-thomas @saif-ellafi