Adopt AnyDateFormatter from Codextended #109
Conversation
|
@JohnSundell here is a friendly ping to let you know that I am interested in getting this PR merged. I am available to address any feedback you might have. Thanks! |
| @@ -18,7 +18,7 @@ let package = Package( | |||
| .package(name: "Ink", url: "https://github.com/johnsundell/ink.git", from: "0.2.0"), | |||
| .package(name: "Plot", url: "https://github.com/johnsundell/plot.git", from: "0.4.0"), | |||
| .package(name: "Files", url: "https://github.com/johnsundell/files.git", from: "4.0.0"), | |||
| .package(name: "Codextended", url: "https://github.com/johnsundell/codextended.git", from: "0.1.0"), | |||
| .package(name: "Codextended", url: "https://github.com/addisonwebb/codextended.git", .branch("update-any-date-formatter")), | |||
There was a problem hiding this comment.
This (and the Package.resolved file) will be updated once the Codextended PR is merged. JohnSundell/Codextended#15
|
@JohnSundell Would you have a half hour to review these PRs sometime soon? It would be nice to get this change merged into the main repo so I can stop pointing to my fork. Let me know if I can help in any way. Thanks! |
|
@JohnSundell I just saw you tagged a new version for this library. I just want to bring this PR to your attention one last time to see if it is something you would be interested in merging. Thanks! |
|
I am no longer using Publish and don't have time to update this PR. |
This PR is dependent on Codextended PR #15. This draft PR will be updated to point to the new version of Codextended once that PR is merged and a new release is tagged.
This PR aims to solve the same issue as #77 and was inspired by @dpfannenstiel.
Why
As a website developer, I would like to use dates formatted according to the ISO 8601 standard.
Problem
Currently, a developer may specify a custom date formatter that is a
DateFormatter. This solution prevents the use ofISO8601DateFormattersince it inherits directly fromFormatterinstead ofDateFormatter.Solution
This change adopts
AnyDateFormatterfrom Codextended. This allows you to use etherDateFormatterorISO8601DateFormatteras thePublishingContext.dateFormatter.This change should be the minimal set of changes required to support
ISO8601DateFormatteras an option for developers. It should not introduce any breaking changes for current Publish users.