Skip to content

Add clean command to CLI - #92

Closed
Kilo-Loco wants to merge 1 commit into
JohnSundell:masterfrom
Kilo-Loco:feature/publish-clean
Closed

Add clean command to CLI#92
Kilo-Loco wants to merge 1 commit into
JohnSundell:masterfrom
Kilo-Loco:feature/publish-clean

Conversation

@Kilo-Loco

Copy link
Copy Markdown
Contributor

Occasionally $ publish run fails due to duplicate files inside the .build folder. This might be a problem on my machine since I have seen this behavior before. However, having a clean command would be nice in the event others are experiencing this and want to have a fresh build next time they run $ publish run.

@JohnSundell

Copy link
Copy Markdown
Owner

I'm very hesitant to accept this change since it makes assumptions about the way the Swift Package Manager is currently implemented (since it assumes that the private build folder will always be .build). I've made these kinds of assumptions in the past and they've been prone to break between different Swift versions, leading to an increased maintenance and compatibility burden. Also, since the Swift Package Manager has a built-in cleaning tool (swift package clean), I'm not sure why Publish would need to ship its own cleaning tool (given that it just uses SwiftPM to orchestrate its build process).

@JohnSundell JohnSundell added the awaiting update Awaiting an update from the PR author label Dec 30, 2020
@Kilo-Loco Kilo-Loco closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting update Awaiting an update from the PR author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants