Synchronize reads/writes to outputData and errorData #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the bug I observed with Lite's parallel test runner. TSan runs clean with this fix. |
Since the FileHandle readabilityHandlers execute asyncronously, possibly on multiple different queues, we need to guard the reads/writes of the outputData/errorData on a serial dispatch queue, and block until all writes have finished.
harlanhaskins
force-pushed
the
on-your-mark-get-set-go
branch
from
096a321
to
6e44fc1
Compare
harlanhaskins
changed the title
JohnSundell
approved these changes
Jan 4, 2018
|
Thanks for the merge! Mind doing another tag on master so I can update https://github.com/silt-lang/Lite's |
|
Sure, will do 👍 |
|
And it's me who should thank you for contributing ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the FileHandle readabilityHandlers execute asyncronously, possibly
on multiple different queues, we need to guard the reads/writes of the
outputData/errorData on a serial dispatch queue, and block until all
writes have finished.