Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over Actions List component #207

Closed
rdig opened this issue Jan 22, 2023 · 1 comment · Fixed by #229
Closed

Port over Actions List component #207

rdig opened this issue Jan 22, 2023 · 1 comment · Fixed by #229
Assignees
@willm30

Comments

@rdig
Copy link
Member

rdig commented Jan 22, 2023 •
edited

  • Bring over, cleanup (imports) and if needed refactor the actions list component
  • Needs to support pagination, but don't handle it here. Will be handled by Refactor / Implement better Actions List Pagination #210
  • No comments (will be handled separately)
  • Transactions log is not part of this
  • Still has the sort functionality (newest/oldest)
  • Don't handle the various tags (Passed, Forced, etc) as they will be handled by the Motions project
  • Don't port over / handle the action notification logic (the one used for Recovery Mode)

Actions Data Flow

Below is a rough outline of how the Actions Data Flow should work

cdapp-actions-data-flow
@willm30 willm30 self-assigned this Jan 25, 2023
This was referenced Jan 26, 2023
Merged
Merged
@willm30 willm30 linked a pull request Jan 31, 2023 that will close this issue
Refactor Actions List Item #229
Merged
@willm30
Copy link
Contributor

willm30 commented Feb 2, 2023

MERGED #231

@willm30 willm30 closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willm30 willm30

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Actions List Item JoinColony/colonyCDapp
2 participants
@rdig @willm30