Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better domain handling in createTask sender #153

Closed
2 of 3 tasks
chmanie opened this issue Jun 3, 2018 · 2 comments
Closed
2 of 3 tasks

Better domain handling in createTask sender #153

chmanie opened this issue Jun 3, 2018 · 2 comments

Comments

@chmanie
Copy link
Member

chmanie commented Jun 3, 2018

Currently the createTask sender requires a domainId to be set. We want to make it a little bit easier for people to use who don't want to concern themselves with domains. So it'd be good to set the default value of domainId to 1 (which is the root domain).

Also, when specifying a domainId which doesn't exist, we get a revert error. We should add some async validation so that it checks whether the domain exists before trying to create the task.

TODO:

  • Make 1 the default domain
  • Adjust the docs (also for the createTask sender) (@gichiba ?)
  • Validate that the domain exists before trying to create a task
@chmanie chmanie added this to the Sprint 3 milestone Jun 3, 2018
@gichiba
Copy link
Contributor

gichiba commented Jun 3, 2018

I added language into the 'get started' doc for the above (into the PR #152), but I think the comments for senders should be changed in the PR that implements the actual code change, right?

@chmanie
Copy link
Member Author

chmanie commented Jun 3, 2018

but I think the comments for senders should be changed in the PR that implements the actual code change, right?

Yes, I hope @JamesLefrere is going to take care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants