Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Bitcoin Core v0.18 #351

Closed
kristapsk opened this issue May 12, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@kristapsk
Copy link
Contributor

commented May 12, 2019

E               subprocess.CalledProcessError: Command '['bitcoin-cli', '-regtest', '-rpcuser=bitcoinrpc', '-rpcpassword=123456abcdef', 'generate', '301']' returned non-zero exit status 32.

/usr/lib64/python3.6/subprocess.py:418: CalledProcessError
------------------------------------------------------------------------------------ Captured stdout setup ------------------------------------------------------------------------------------
Here is the bitcoin_conf path:
/dev/shm/jm_test_home/.bitcoin/bitcoin.conf
------------------------------------------------------------------------------------ Captured stderr setup ------------------------------------------------------------------------------------
error code: -32
error message:
The wallet generate rpc method is deprecated and will be fully removed in v0.19. To use generate in v0.18, restart bitcoind with -deprecatedrpc=generate.
Clients should transition to using the node rpc method generatetoaddress

generate should be changed to generatetoaddress.

@AdamISZ

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Thanks for the heads up. I will fix it shortly then.

@AdamISZ

This comment has been minimized.

Copy link
Member

commented May 13, 2019

See #352 - seem to be working fine. Let me know if you see a problem. And feel free to run it if you like but if it passes travis I'll just merge it anyway.

In other news, what exactly was the point of making this a breaking RPC change?! What's wrong with having a default with no address, I can't understand it.

@kristapsk

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Removal of generate was discussed in bitcoin/bitcoin#14299. Main reasoning, as I understand, was "removes a wallet->server dependency and simplifies the wallet->server interface".

@kristapsk

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Resolved in #352.

@kristapsk kristapsk closed this May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.