Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade testing framework to use generatetoaddress. #352

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@AdamISZ
Copy link
Member

commented May 13, 2019

Prior to this commit, the regtest testing framework
used the bitcoin rpc command generate to mine coins
in preparation for tests, and to tick forward the
chain for confirmations. This rpc command is deprecated
and will be removed in 0.19. Hence this commit changes
the two usages of generate to generatetoaddress and
specifies a mining address created with getnewaddress.

Upgrade testing framework to use generatetoaddress.
Prior to this commit, the regtest testing framework
used the bitcoin rpc command `generate` to mine coins
in preparation for tests, and to tick forward the
chain for confirmations. This rpc command is deprecated
and will be removed in 0.19. Hence this commit changes
the two usages of `generate` to `generatetoaddress` and
specifies a mining address created with `getnewaddress`.
@AdamISZ

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

Tested as working on 0.17 and 0.18 (i.e. ran the full test suite on both locally and it worked).

@kristapsk
Copy link
Contributor

left a comment

tACK 31eabde (with Bitcoin Core 0.18)

@AdamISZ AdamISZ merged commit 31eabde into master May 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

AdamISZ added a commit that referenced this pull request May 13, 2019

Merge #352: Upgrade testing framework to use generatetoaddress.
31eabde Upgrade testing framework to use generatetoaddress. (AdamISZ)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.