Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when pushing TX via "not-self" #365

Merged
merged 1 commit into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@AlexCato
Copy link
Contributor

commented Jul 8, 2019

Ran into a crash with sendpayment today, when tx_broadcast in joinmarket.cfg is set to not-self.

Before the change, it crashed on the modified line because type dict_keys is returned here, which cannot be used with an index:

(Pdb) type(self.maker_utxo_data.keys())
<class 'dict_keys'>

Fix crash when pushing TX via "not-self"
Ran into a crash with sendpayment today, when tx_broadcast in joinmarket.cfg is set to not-self.

Before the change, it crashed on the modified line because type dict_keys is returned here, which cannot be used with an index.
@AlexCato

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

And tested on main net that this indeed fixes it.

@kristapsk
Copy link
Contributor

left a comment

tACK 1caf0da on mainnet (except that nobody of not-self parties actually broadcasted by test tx, did sendrawtransaction manually afterwards, but this change apparently didn't introduce any new errors)

@AlexCato

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Can confirm that the tx was not broadcast. I ran out of time when I was trying to debug that.

Only got so far: take does send the push command to a maker according to logs, then quits. When I checked on the maker side, there was no log entry about this whatsoever. Hunch: maybe due to throttling it doesnt send the irc message right away, but when it could be re-transmit, the taker script already quit?
New issue about that, so it's not forgotten: #368

@chris-belcher chris-belcher merged commit 1caf0da into JoinMarket-Org:master Jul 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

chris-belcher added a commit that referenced this pull request Jul 9, 2019

Merge #365: Fix crash when pushing TX via "not-self"
1caf0da Fix crash when pushing TX via "not-self" (AlexCato)

Tree-SHA512: 7f9033993602071c81b6526a2b35a5ed1ee7eb9bbd9bc937fe7838d11b3091acaec46ee0ecebc4136470fe5dd70540acbbda8458e8250b5e76c248499fba63c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.