Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generic type constraints from IEventFilter and IRequestFilter #100

Closed
JonasSamuelsson opened this issue Aug 24, 2020 · 0 comments
Closed

Remove generic type constraints from IEventFilter and IRequestFilter #100

JonasSamuelsson opened this issue Aug 24, 2020 · 0 comments
Labels
Handyman.Mediator
Milestone
mediator v10

Comments

@JonasSamuelsson
Copy link
Owner

JonasSamuelsson commented Aug 24, 2020 •
edited

With the current implementations filters apply to all or one event or request.

Make it possible to target a subset of events, requests or responses by removing the generic type constraints from IEventFilter and IRequestFilter.
@JonasSamuelsson JonasSamuelsson added this to the mediator v10 milestone Aug 25, 2020
@JonasSamuelsson JonasSamuelsson changed the title Look in to adding co/contra-variance to I[Event/Request][Filter/Handler] and friends add co/contra-variance to event & request filters Aug 28, 2020
@JonasSamuelsson JonasSamuelsson changed the title add co/contra-variance to event & request filters add event & request filter contravariance Aug 28, 2020
JonasSamuelsson pushed a commit that referenced this issue Aug 29, 2020
@jonassamuelssoncab
added event filter contravariance
4a19448 
 #100
JonasSamuelsson pushed a commit that referenced this issue Sep 1, 2020
@jonassamuelssoncab
changed the IEventFilter signature to take a context and next delegat…
6d08f80 
…e & updated the event filter type constraint test

#100
JonasSamuelsson pushed a commit that referenced this issue Sep 1, 2020
@jonassamuelssoncab
removed IRequestFilter type constraint
f6bc0ab 
#100
@JonasSamuelsson JonasSamuelsson changed the title add event & request filter contravariance Remove generic type constraints from IEventFilter and IRequestFilter Sep 1, 2020
JonasSamuelsson pushed a commit that referenced this issue Sep 20, 2020
@jonassamuelssoncab
added event filter contravariance
97e06ee 
 #100
JonasSamuelsson pushed a commit that referenced this issue Sep 20, 2020
@jonassamuelssoncab
changed the IEventFilter signature to take a context and next delegat…
0a83fba 
…e & updated the event filter type constraint test

#100
JonasSamuelsson pushed a commit that referenced this issue Sep 20, 2020
@jonassamuelssoncab
removed IRequestFilter type constraint
edc298c 
#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Handyman.Mediator
Projects
None yet
Milestone
mediator v10
Development

No branches or pull requests
1 participant
@JonasSamuelsson