Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PE format documentation #439

Closed
JonathanSalwan opened this issue Jan 2, 2017 · 2 comments
Closed

PE format documentation #439

JonathanSalwan opened this issue Jan 2, 2017 · 2 comments
Labels
Documentation Enhancement libTriton Windows
Milestone
v0.5

Comments

@JonathanSalwan
Copy link
Owner

JonathanSalwan commented Jan 2, 2017 •
edited

Hey @gyorokpeter,

Can you please improve these following documentations:

After these changes, I will merge into master. Thanks and great job about the PE support :)
@JonathanSalwan JonathanSalwan added this to the v0.5 milestone Jan 2, 2017
@gyorokpeter
Copy link
Contributor

For PE32_OptionalHeader and PE32Plus_OptionalHeader, each field has the same function as in PeOptionalHeader. Should I copy the field descriptions one by one, or is it enough to mention this before the two structs?

@JonathanSalwan
Copy link
Owner Author

Should I copy the field descriptions one by one, or is it enough to mention this before the two structs?

It's ok if you described it into the struct description but it must be mentioned over the doxygen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Enhancement libTriton Windows
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
2 participants
@JonathanSalwan @gyorokpeter