fix for thoughtbot#52

JonathanTron · Jun 2, 2011 · 66a6145 · 66a6145
1 parent e121981
commit 66a6145
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/spec/driver_spec.rb b/spec/driver_spec.rb
@@ -167,6 +167,11 @@
       subject.current_url.should =~ /hello%20there/
     end
 
+    it "visits a page with an anchor" do
+      subject.visit("/hello#display_none")
+      subject.current_url.should =~ /hello#display_none/
+    end
+
     it "returns the source code for the page" do
       subject.source.should =~ %r{<html>.*greeting.*}m
     end

diff --git a/src/Visit.cpp b/src/Visit.cpp
@@ -7,7 +7,12 @@ Visit::Visit(WebPage *page, QObject *parent) : Command(page, parent) {
 }
 
 void Visit::start(QStringList &arguments) {
-  page()->currentFrame()->setUrl(QUrl(arguments[0]));
+  QUrl requestedUrl = QUrl(arguments[0]);
+  page()->currentFrame()->setUrl(QUrl(requestedUrl));
+  if(requestedUrl.hasFragment()) {
+    // workaround for https://bugs.webkit.org/show_bug.cgi?id=32723
+    page()->currentFrame()->setUrl(QUrl(requestedUrl));
+  }
 }
 
 void Visit::loadFinished(bool success) {
@@ -17,4 +22,3 @@ void Visit::loadFinished(bool success) {
 
   emit finished(new Response(success, message));
 }
-
diff --git a/src/Visit.h b/src/Visit.h
@@ -13,4 +13,3 @@ class Visit : public Command {
     void loadFinished(bool success);
 };
 
-