-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml and move metadata from setup.py #211
Conversation
e27eb11
to
9760eb1
Compare
This is a step toward modernizing the project packaging, and allows us to begin defining tooling config in pyproject.toml. References: - https://packaging.python.org/en/latest/specifications/declaring-project-metadata/ Tested: - python3 -m build - diff generated .dist-info/* files and ensure only minimal, expected changes
This the more modern, flexible frontend for building packages. Also, it provides build isolation which should avoid setuputils-version-related issues.
9760eb1
to
2c5ae0a
Compare
This build (and others) failed because the resulting dist is named The Maybe the right idea is to just invoke |
After switching to The reason is that Why not? Because when we run the tests from the project root, the How to fix this? My initial thought is to just blast
|
Also add names to all steps.
This will ensure that only the package from the installed wheel is used.
c766f2f
to
7c95e7f
Compare
This is a step toward modernizing the project packaging, and allows us to begin defining tooling config in
pyproject.toml
.References:
Tested:
python3 -m build
scuba-*.dist-info/*
files and ensure only minimal, expected changesCloses #203