scuba: Use importlib.metadata over pkg_resources #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 5 files 5 suites 1m 32s ⏱️ Results for commit c5c5233. ♻️ This comment has been updated with latest results. |
JonathonReinhart
force-pushed
the
245-remove-pkg_resources
branch
2 times, most recently
from
a9f4e19
to
b9cc16a
Compare
pkg_resources is deprecated: https://setuptools.pypa.io/en/latest/pkg_resources.html This prefers importlib.metadata (introduced in Python 3.8) and uses the backport importlib_metadata for Python 3.7 (to be removed in #242). Fixes #245
JonathonReinhart
force-pushed
the
245-remove-pkg_resources
branch
from
b9cc16a
to
c5c5233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated.
Fixes #245