Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
improve installing via pip #121
isrcsubmit needs at least one non-python package (libdiscid, C library), so it can't be installed completely via pip.
Pip then probably only installs into /usr/local/bin, which might or might not be in the $PATH.
This was probably the purpose of #116, even though was not mentioned in the subject.
I nearly forgot: the recommended install of the dependencies is either via the package manager (on linux), as that installs also libdiscid or to use one of the packages mentioned here (also including a libdiscid binary for Windows and Mac):
The current use of:
Does not work. By the time setuptools has parsed this, the previous use of
There are three possible solutions:
After also fixing python-discid and testing with
I am not going to fix this now, as it would be a bit more complex.
Just for reference there is another alternative library, python-libdiscid which is using the same C library libdiscid. It is not using ctypes but is compiled against libdiscid directly. This fails on install:
So it has the advantage to fail early, but it also needs the header files (which python-discid doesn't) and the error message you get might not be "straightforward".