mediatools/windows backend

[JonnyJD]

There is already a windows tool to submit ISRCs: http://forums.musicbrainz.org/viewtopic.php?id=1838
and I don't use windows.

However, there are request of getting ISRCs with mediatools because the algorithm will always (?) get correct ISRCs.

Additionally the windows tool still has the same problems with multi-disc releases we had with #16

[JonnyJD]

The command line mediatools: http://www.flanagan-family.com/mediatools.zip
There is some information on the forums about mediatools: http://forums.musicbrainz.org/viewtopic.php?pid=9578#p9578

There is also a full isrc submit tool based on mediatools: http://forums.musicbrainz.org/viewtopic.php?id=2116

If the mediatools based isrc submit gui works good, then there is not that much of a need to implement windows support our this isrcsubmit.

[jesus2099]

Thanks for this issue Jonny !
As I said, the problems with isrcsubmit.exe are

• algorithm not as robust as mediatools.exe’s (cf. line #263) → frequent inaccurate CD drives cause duplicate ISRC.
• cannot submit to multi-disc releases

[JonnyJD]

There are also windows builds of cdrdao at http://www.student.tugraz.at/thomas.plank/

A possibly bigger problem is that there is only a windows build for libdisc-1.1 which itself complains about a missing MSVCR71.dll, which should go with the lib, I think.
A guide to build libdiscid can be found here: http://forums.gcstar.org/viewtopic.php?id=1825

We need to find a way to look up what backend is available. The which approach doesn't work on windows.

[JonnyJD]

Like I suspected: In my virtual machine (virtualbox) mediatools drive D isrcs only gives

ISRCS STARTS
ISRC    01
ISRCS ENDS

So I can't test much on my own machine. I have to see if I can get a hold of a real windows machine.

But first I need to get libdiscid to work.

EDIT:
With media_info d I get: DeviceIOControl with SCSI_PASS_THROUGH_DIRECT command failed. Looks much like a virtualization problem.

[JonnyJD]

Okay, this is how it looks on a real windows machine.

ISRCS STARTS
ISRC    01      GBAMC0300001
ISRC    02      GBAMC0300002
ISRC    03      GBAMC0300003
ISRC    04      GBAMC0300004
ISRC    05      GBAMC0300005
ISRC    06      GBAMC0300006
ISRC    07      GBAMC0300007
ISRC    08      GBAMC0300008
ISRC    09      GBAMC0300009
ISRC    10      GBAMC0300010
ISRC    11      GBAMC0300011
ISRCS ENDS

I still need a good libdiscid binary for windows.

[jesus2099]

mediatools is quite raw, it seems you can’t use on fake windows.
Don’t worry though, Jonny, I have other means of submitting (OK they are less easy), you can put this as less priority, really. :)

[JonnyJD]

I took the libdiscid build from the windows version of picard:
https://github.com/downloads/JonnyJD/musicbrainz-isrcsubmit/libdiscid-0.2.2-win32.zip

This seems to work in general, but in my virtual machine it's giving wrong discIDs. Again, this is probably a virtualization problem. I will have to re-check this on a real machine.

[jesus2099]

I can test whatever you want me to test. :)

[JonnyJD]

Not yet. I will ask you again when I have something fairly complete (= easy to test)

[JonnyJD]

windows branch should work on windows together with discid.dll and cdrdao (cdrdao.exe, cyggcc_s-sjlj-1.dll, cygwin1.dll). All executables, dlls and the musicbrainz2 directory in the same folder as isrcsubmit.py.
I couldn't test that yet, though.

The mediatools backend is not in place yet.

[JonnyJD]

This should work now. I created a preview package at http://kraehen.org/tmp/isrcsubmit-0.5-win32.zip

It would be nice if you could test it. I would also like to hear feedback about the packaging. I created isrcsubmit.bat. When you create a windows shortcut for that batchfile (and append arguments as you wish in the shortcut) you should be able to work with this quite comfortably.