New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first disc (cd) mistaken for last disc (= dvd) #25

Closed
JonnyJD opened this Issue Nov 20, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@JonnyJD
Owner

JonnyJD commented Nov 20, 2012

example:
http://musicbrainz.org/edit/19736151

When our discId is the last discId found for a release in the database, we guess this is the last disc for the release.
However, there can be another disc after that if that disc has no discId. This is always the case for (bonus) DVDs.

The frequent case CD+DVD is only affected if there are multiple discIds given for the first disc AND our discId is the last discId in the list.

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Nov 20, 2012

We have two possibilties:

  1. We don't guess discs as beeing the last disc and ask for an offset (which makes submitting of 2-disc releases quite painful)
  2. We still tell our guess (and what that means for the offset), but we do ask for the offset
@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Nov 20, 2012

This is somehwat related to the old #16

@ghost ghost assigned JonnyJD Nov 30, 2012

@JonnyJD JonnyJD closed this in f8a9286 Nov 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment