New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventing duplicate ISRCs #3

Closed
JonnyJD opened this Issue Feb 4, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@JonnyJD
Owner

JonnyJD commented Feb 4, 2012

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Feb 10, 2012

  1. We want to prevent submitting an ISRC we found to two different tracks -> prevent clear mistakes on our part -> Error if we find something like that
  2. Try to fix/prevent duplicate ISRCs in general, even if we actually don't do anything wrong ourselves -> Only a warning.
  3. OPTIONAL: Possibly giving the option to show every track listed for our ISRCs to do some majore collision clean-up. This is something you might only want to do for BIG releases (many tracks per ISRC) and if you have some time to spare. Additionally the edititing/fixing should be done completely in the browser. This is only done because you have a better chance to fix those collisions when you know one ISRC-recording relation for sure.
@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Feb 10, 2012

Number 3 might better be done with web service 2. Then we can actually get all the recordings for one ISRC with one request. Drastically reducing the work for us and the server.

Additionally, there might not be as much ISRC collisions as with PUIDs and most collisions are on one release, probably. We want to solve that with 2.

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Feb 10, 2012

An example for 1. in my collection is London Calling by The Clash:
http://musicbrainz.org/cdtoc/hSI7B4G4AkB5.DEBcW.3KCn.D_E-
http://forums.musicbrainz.org/viewtopic.php?pid=9159#p9159

I have a DVD-Writer that gives normal result and a DVD-Reader giving GBBBN7902019 for track 3 AND 4.

This is ALSO an example of 2. (before I fix it). Track 18 AND 19 both have the same ISRCS (as my DVD-reader also tries to tell me).

JonnyJD added a commit that referenced this issue Feb 10, 2012

re #3, detect duplicate ISRCs given by the cd drive.
An error is printed when icedax detects the same ISRC for different
tracks on our disc. This doesn't check the ISRCs given by the server,
yet.

@ghost ghost assigned JonnyJD Feb 19, 2012

@JonnyJD JonnyJD closed this in 0f7d019 Feb 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment