New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting release and quitting program #32

Closed
jesus2099 opened this Issue Dec 11, 2012 · 9 comments

Comments

Projects
None yet
3 participants
@jesus2099
Contributor

jesus2099 commented Dec 11, 2012

Could it be possible to start the release number from 1 instead of from 0 in please select your release
And could we have the 0 for quitting program (no other way than CTRL+C now, and this is not good result when using a dos.bat file which then asks for quit confirm).

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Dec 11, 2012

There was a recent change in #26
It was previously possible to quit just pressing without any input. Currently it just asks again until you give a valid input.

Starting with 0 comes natural because this is how arrays work in python, but adding an offset of 1 is possible.
Not really sure if it wouldn't be better having q or similar for quitting. 0 is not necessarily intuitive for quitting.

Why do you use a dos.bat and why do you catch CTRL+C there?
You can just start isrcsubmit.bat directly. This will also make sure you don't close cmd before you have seen the last output.
Do you have a bigger workflow including ripping and stuff?

@jesus2099

This comment has been minimized.

Contributor

jesus2099 commented Dec 11, 2012

My isrc.bat has access to mediatools.exe (m), isrcsubmit.exe (i) and your new shiny isrcsubmit.py (p default).
I just have to type either isrc, isrc p, isrc m or isrc i and each one will have all the possible parameters set for me.

I still need isrcsubmit.exe because #34.

I agree 0 for exit is not good. Actually in isrcsubmit.exe if you press any other key it would exit.
Starting from 1 seems more natural for human reading list. ;)

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Dec 11, 2012

Well, at the time isrcsubmit asks you for the release, any invalid input will just exit. (just like in isrcsubmit.exe)

However, later on in the script, like when asked for the offset, it will only exit on CTRL-C, because you might not want to exit on a whim after reading the ISRCs and making a couple of choices.

@Freso

This comment has been minimized.

Contributor

Freso commented Dec 11, 2012

I don't really think it matter whether we're counting from 0 or 1. Whichever is more intuitive for the coder.

This is a CLI script. It's not going to be something Windows users at large will use. It's not going to be as widely "popular" as Picard. It's a niche script for crazy, obsessive-compulsive editors that wants to add everything. So. Just keep Python's own array numbering instead of adding more code (that will also need to be kept updated, ported to Py3 at some point, etc.) for little to no gain.

IMHO.

@jesus2099

This comment has been minimized.

Contributor

jesus2099 commented Dec 14, 2012

Forget the key to quit, I thought it didn’t quit when just pressing ENTER key but it actually does…
In a program, be it a CLI script, I don’t think the GUI should ever be whichever is more intuitive for the coder. ;p
I maintain the 1-4 instead of 0-3 selection prompt, just in case you eventually agree. ^^;

@JonnyJD JonnyJD closed this Jan 26, 2013

@jesus2099

This comment has been minimized.

Contributor

jesus2099 commented Jan 26, 2013

You eventually still don’t like it to number choices from 1 instead of from 0, then ?
I keep mistaking and slowing down (because must think twice before press key) but if most prefer 0, then... :)

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Jan 26, 2013

To be fair, I don't know what most users prefer. I don't get that much feedback and the feedback I get is mostly from users at github (where many are devs/tech-savy).

I only know that using 1 to n is a major source of bugs in general, especially because this is a small (1 file) script without a separate user interface. The logic and the interface are tightly coupled.
That is in contrast to tools like Picard, which has 40 source files alone for the interface.
With the right abstraction it is no problem.

That being said, I will change it anyways, since it does seem to be more than a minor annoyance to you and possibly others.
This won't be in any 0.5.x release, because this is a change in the interface and might confuse others ;-)

@ghost ghost assigned JonnyJD Jan 26, 2013

@JonnyJD JonnyJD reopened this Jan 26, 2013

@JonnyJD JonnyJD closed this in ee94625 Jan 26, 2013

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Jan 26, 2013

Fixed. Should be in the next (feature) release

@jesus2099

This comment has been minimized.

Contributor

jesus2099 commented Jan 26, 2013

Thanks very much for this personal fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment