Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discisrc/libdiscid backend (Mac/Win/Linux) #35

Closed
JonnyJD opened this issue Dec 11, 2012 · 6 comments

Comments

@JonnyJD
Copy link
Owner

commented Dec 11, 2012

There is a libdiscid branch that reads ISRCs on Mac:
http://bugs.musicbrainz.org/browser/libdiscid/branches/isrc/src/disc_darwin.c
http://bugs.musicbrainz.org/browser/libdiscid/branches/isrc/examples/discisrc.c

This is supposed to be much faster than drutil.

EDIT:
starting with libdiscid 0.3.2 this backend is also for Linux available (and since 0.3.0 for Mac and Windows)

@JonnyJD

This comment has been minimized.

Copy link
Owner Author

commented Dec 11, 2012

example output: (http://lmfao.org.uk/isrc)

$ ./examples/discisrc
MCN      : 4942463505127
Track 1  : JPA600000650
Track 2  : JPA609901420
Track 3  : JPA600000660
Track 4  : JPA600000670
Track 5  : JPA609903040
Track 6  : JPA600000680
Track 7  : JPA600000690
Track 8  : JPA600000700
Track 9  : JPA600000710
Track 10 : JPA600000720
Track 11 : JPA600000730
Track 12 : JPA600000740

The output of discid: http://lmfao.org.uk/isrc2

@JonnyJD

This comment has been minimized.

Copy link
Owner Author

commented Dec 11, 2012

This should also work on Windows:
http://bugs.musicbrainz.org/browser/libdiscid/branches/isrc/src/disc_win32_new.c

It doesn't work on Linux, because there is no code present (and it is more difficult code-wise).
There is code in the repo that uses cdrdao to gather the ISRCs on linux.

@JonnyJD

This comment has been minimized.

Copy link
Owner Author

commented Dec 11, 2012

I created a universal build (32/64 bit) of discisrc: (broken link removed)

@JonnyJD

This comment has been minimized.

Copy link
Owner Author

commented Dec 12, 2012

The discisrc download is not working (probably because github stopped uploads the same day.
Additionally, the dynamic build had huge problems actually finding the dylib.

So I created a static build of discisrc and hosted it on my own server:
http://isrcsubmit.jonnyjd.net/downloads/discisrc-mac.zip

That build is ONLY for 64 bit intel macs. If anybody can provide a 32 bit build, send it to me.

@JonnyJD

This comment has been minimized.

Copy link
Owner Author

commented Jan 10, 2013

libdiscid 0.3.0 does support gathering isrcs on win32 and mac, but this doesn't help much at the moment, since we don't have an API for that at the moment.
See: metabrainz/libdiscid@0c89f25...b987a7b

@JonnyJD

This comment has been minimized.

Copy link
Owner Author

commented Feb 16, 2013

https://github.com/JonnyJD/python-discid will provide an API for isrcs in libdiscid.

Libdiscid 0.3.2 can read ISRCs for Mac/Darwin, Windows and Linux.
Later versions should fix the duplicate slide down bug: metabrainz/libdiscid#6

@JonnyJD JonnyJD closed this in df23fc2 Feb 16, 2013

@ghost ghost assigned JonnyJD Feb 16, 2013

JonnyJD added a commit that referenced this issue Mar 12, 2013

fix discisrc backend for mac, re #35
On Mac it also needs get_real_mac_device()

Additionally I added "." to the PATH in isrcsubmit.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.