Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor+fix submit/verify disc id #39

Closed
JonnyJD opened this issue Dec 17, 2012 · 1 comment
Closed

refactor+fix submit/verify disc id #39

JonnyJD opened this issue Dec 17, 2012 · 1 comment
Assignees
Milestone

Comments

@JonnyJD
Copy link
Owner

@JonnyJD JonnyJD commented Dec 17, 2012

Clean up after implementing #14

submit should be renamed to verified in most places or similar. It is all about verification, not about whether we want to submit at all. The user decides if he wants to submit in the end.

JonnyJD pushed a commit that referenced this issue Feb 16, 2013
@JonnyJD
Copy link
Owner Author

@JonnyJD JonnyJD commented Feb 16, 2013

While refactoring I realized: d7f0d96 actually broke recalculation.

Another reason why refactoring is good ;-)

@JonnyJD JonnyJD closed this in bdb8efc Feb 16, 2013
@ghost ghost assigned JonnyJD Feb 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant