New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Y` is not recognized by the prompt in v2.0.0 #98

Closed
CyberSkull opened this Issue Feb 10, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@CyberSkull

CyberSkull commented Feb 10, 2015

I went through and got a bunch of ISRCs ready to submit, and when prompted, I entered Y (instead of y) and then it replied that nothing had been submitted.

Do you want to submit? [y/N] Y
Nothing was submitted to the server.

So I re-ran the command and when I came to the submit prompt I typed y and it worked.

Do you want to submit? [y/N] y

Successfully submitted 24 ISRCS.

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Feb 10, 2015

Indeed we shouldn't be case sensitive here. I'll fix that.

@JonnyJD JonnyJD added this to the 2.0.1 milestone Feb 10, 2015

@JonnyJD JonnyJD added the usability label Feb 10, 2015

JonnyJD added a commit that referenced this issue Feb 10, 2015

@JonnyJD JonnyJD self-assigned this Feb 10, 2015

@JonnyJD

This comment has been minimized.

Owner

JonnyJD commented Feb 10, 2015

Should be fixed with #99

@CyberSkull

This comment has been minimized.

CyberSkull commented Feb 10, 2015

All prompts should generally be case insensitive. What I normall do is prior to checking my prompt, I chomp out whitespaces, then if I have a case sensitive comparison function I change my input to lower case and only then compare to my list of valid commands.

@JonnyJD JonnyJD closed this in #99 Jun 4, 2015

JonnyJD added a commit that referenced this issue Jun 4, 2015

Merge branch 'case'
see pull request #99
fix #98

JonnyJD added a commit that referenced this issue Jun 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment